src: changing node_file's usage of v8::Resolver#18765
Closed
MSLaguana wants to merge 1 commit intonodejs:masterfrom
Closed
src: changing node_file's usage of v8::Resolver#18765MSLaguana wants to merge 1 commit intonodejs:masterfrom
MSLaguana wants to merge 1 commit intonodejs:masterfrom
Conversation
node_file was casting back and forth between v8::Resolver and v8::Promise This is unnecessary; most of the time it just wants the v8::Resolver, converting to the v8::Promise only as a return value.
nodejs-github-bot
added
c++
cjihrig
approved these changes
Feb 13, 2018
jasnell
approved these changes
Feb 13, 2018
kfarnung
approved these changes
Feb 14, 2018
Contributor
|
The only remaining CI failure is: nodejs/build#1126 This is unrelated to the change. |
BridgeAR
added
the
author ready
Contributor
|
Landed in 197258b |
kfarnung
pushed a commit
that referenced
this pull request
Feb 16, 2018
node_file was casting back and forth between v8::Resolver and v8::Promise. This is unnecessary; most of the time it just wants the v8::Resolver, converting to the v8::Promise only as a return value. PR-URL: #18765 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
2 tasks
Contributor
|
Should this be backported to |
Contributor
Author
|
With the current state of |
Contributor
Author
|
Ah; I see its PR lists the |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
node_file was casting back and forth between v8::Resolver and v8::Promise. This is unnecessary; most of the time it just wants the v8::Resolver, converting to the v8::Promise only as a return value. PR-URL: nodejs#18765 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node_file was casting back and forth between
v8::Promise::Resolverandv8::PromiseThis is unnecessary; most of the time it just wants the
v8::Promise::Resolver,converting to the
v8::Promiseonly as a return value.This was causing issues for node-chakracore, since the v8 shim that we use there did not have
v8::Promiseas pointer-convertible withv8::Promise::Resolver.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src